-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower dependencies too restrictive #21
Comments
I'm also wondering why ignore list contains "src" folder. |
Hi @ram-one, I think we should also change main to:
I'm not sure about the src folder. I've checked some projects, and some of them include this folder (ex: jQuery) and others don't (ex: Leaflet). Initially, you shouldn't use the files of src folder, as you have them concatenated and minified at dist. Any suggestion @fox91? |
Yes, main is also wrong because bower will ignore src folder when downloading the package so automated tool that uses the main declaration won't find theses. Including src allows custom builds. For example I don't want the player control because I use mine. |
Hi @bielfrontera, Dependencies suggested by @ram-one seem appropriate. |
Hi @bielfrontera, |
Ok! Updated the version number to 0.1.7 and built with the enhancement for leaflet 1.0. |
After #20, which is a good thing, I was about to do it myself.
May I suggest :
Because you use almost use nothing from jquery ($.ajax), you don't need a specific version.
You also support leaflet 1.0
The text was updated successfully, but these errors were encountered: