Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower dependencies too restrictive #21

Closed
r1m opened this issue Dec 2, 2015 · 6 comments
Closed

Bower dependencies too restrictive #21

r1m opened this issue Dec 2, 2015 · 6 comments

Comments

@r1m
Copy link
Contributor

r1m commented Dec 2, 2015

After #20, which is a good thing, I was about to do it myself.
May I suggest :

"dependencies": {
    "iso8601-js-period": "*",
    "leaflet": "~0.7.4 || ~1.0.0",
    "jquery": "1.x || 2.x"
    "jquery-ui": ">=1.10"
  }

Because you use almost use nothing from jquery ($.ajax), you don't need a specific version.
You also support leaflet 1.0

@r1m
Copy link
Contributor Author

r1m commented Dec 2, 2015

I'm also wondering why ignore list contains "src" folder.

@bielfrontera
Copy link
Contributor

Hi @ram-one,
ok, I'm changing the dependencies.

I think we should also change main to:

  "main": [
    "dist/leaflet.timedimension.src.js",
    "dist/leaflet.timedimension.control.css",
  ],

I'm not sure about the src folder. I've checked some projects, and some of them include this folder (ex: jQuery) and others don't (ex: Leaflet). Initially, you shouldn't use the files of src folder, as you have them concatenated and minified at dist.

Any suggestion @fox91?

@r1m
Copy link
Contributor Author

r1m commented Dec 3, 2015

Yes, main is also wrong because bower will ignore src folder when downloading the package so automated tool that uses the main declaration won't find theses.

Including src allows custom builds. For example I don't want the player control because I use mine.
If the folder is in ignore list, it is simply not donwloaded.

@fox91
Copy link
Contributor

fox91 commented Dec 3, 2015

Hi @bielfrontera,
I also looked at how it is implemented in other projects.
I think the src folder is essential for the development phase (git clone or npm) but not in the integration phase (bower), following the philosophy of Leaflet.
In any case it is a decision they make the developers of each project, as there are no real guidelines on the folders to skip.
Include the dist/ folder in the main is definitely correct.

Dependencies suggested by @ram-one seem appropriate.

@fox91 fox91 mentioned this issue Dec 3, 2015
@fox91
Copy link
Contributor

fox91 commented Dec 3, 2015

Hi @bielfrontera,
I have included some changes in the pull request #22.
If you proceed with the merge you must first regenerate the dist/ folder.

@bielfrontera
Copy link
Contributor

Ok! Updated the version number to 0.1.7 and built with the enhancement for leaflet 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants