Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeGenerator - suggestions #13

Open
MFlisar opened this issue Jun 23, 2015 · 3 comments
Open

CodeGenerator - suggestions #13

MFlisar opened this issue Jun 23, 2015 · 3 comments

Comments

@MFlisar
Copy link

MFlisar commented Jun 23, 2015

I would have following suggestions:

  1. if I use an abstract base class, the generator should at check the base class fields for private fields as well
  2. the generator could create an empty constructor
  3. it could also create the import statement for @ParcelablePlease annotation
@sockeqwe
Copy link
Owner

Hi, thanks for your feedback:

  1. private fields can not be supported because of visibility issues. However, default and public fields in classes are supported
  2. I will try to do add that to the intellij plugin IntelliJ Plugin: generate empty constructor #15
  3. That is a bug and I will fix that IntelliJ Plugin: Import are missing #14

@MFlisar
Copy link
Author

MFlisar commented Jun 23, 2015

  1. I just meant that the generator gives an error if I use private fields in the main class. If I use them in an abstract base class, it just skips them and does not parcel them (no message, either warning no error is visible)

@sockeqwe
Copy link
Owner

Ah, I see... now I understand what you mean ... I will check that! Thanks for reporting!

@sockeqwe sockeqwe reopened this Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants