Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra file in the 0.2.0 Maven release #3

Closed
scompt opened this issue Oct 28, 2015 · 2 comments
Closed

Extra file in the 0.2.0 Maven release #3

scompt opened this issue Oct 28, 2015 · 2 comments

Comments

@scompt
Copy link

scompt commented Oct 28, 2015

It looks like an extra class file got included in the 0.2.0 .AAR file. Here's the error I get when ProGuard gets run:

Warning: com.hannesdorfmann.debugoverlay.DebugOverlayService$logMsg$1: can't find referenced method 'void destroyView()' in program class com.hannesdorfmann.debugoverlay.DebugOverlayService
Warning: com.hannesdorfmann.debugoverlay.DebugOverlayService$logMsg$1: can't find referenced class kotlin.jvm.internal.KotlinSyntheticClass
Warning: com.hannesdorfmann.debugoverlay.DebugOverlayService$logMsg$1: can't find referenced class kotlin.jvm.internal.KotlinSyntheticClass$Kind
Warning: com.hannesdorfmann.debugoverlay.DebugOverlayService$logMsg$1: can't find referenced class kotlin.jvm.internal.KotlinCallable

If I look at the contents of the .AAR downloaded from Maven Central, it contains these classes:

➜  maven  jar xf debugoverlay-0.2.0.aar && jar tvf classes.jar
     0 Wed Oct 14 03:29:26 CEST 2015 META-INF/
    25 Wed Oct 14 03:29:26 CEST 2015 META-INF/MANIFEST.MF
     0 Wed Oct 14 00:53:56 CEST 2015 com/
     0 Wed Oct 14 00:53:56 CEST 2015 com/hannesdorfmann/
     0 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/
   615 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/BuildConfig.class
  1823 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlay$1.class
  2346 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlay$MessageDispatcher.class
  3019 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlay.class
   945 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService$1.class
   813 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService$DebugOverlayServiceBinder.class
  1364 Wed Oct 14 03:03:58 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService$logMsg$1.class
  2007 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService.class
  3823 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/DebugOverlayView.class
  1472 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/LoggingAdapter.class
  2364 Wed Oct 14 03:29:26 CEST 2015 com/hannesdorfmann/debugoverlay/SimpleAdapter.class

The contents of my self-built 0.2.0 AAR file look like this:

➜  aar git:(cd4b8af) jar xf overlay-release.aar && jar tvf classes.jar
     0 Wed Oct 28 10:23:32 CET 2015 META-INF/
    25 Wed Oct 28 10:23:32 CET 2015 META-INF/MANIFEST.MF
     0 Wed Oct 28 10:23:32 CET 2015 com/
     0 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/
     0 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/
   615 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/BuildConfig.class
  1812 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlay$1.class
  2385 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlay$MessageDispatcher.class
  3020 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlay.class
   938 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService$1.class
   813 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService$DebugOverlayServiceBinder.class
  2010 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlayService.class
  3731 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/DebugOverlayView.class
  1472 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/LoggingAdapter.class
  2364 Wed Oct 28 10:23:32 CET 2015 com/hannesdorfmann/debugoverlay/SimpleAdapter.class

I think it would be enough to re-release 0.2.0 and make sure to clean the workspace first. I'm not sure if it would be necessary to bump the version number.

@sockeqwe
Copy link
Owner

yep, sorry ... originally I have written this library in kotlin and it seems that some old and obsolete kotlin artifacts has been added to the .aar unintentionally. Thanks for reporting, i will rerelase a clean version

@sockeqwe
Copy link
Owner

I have re-uploaded a clean version of 0.2.0 to maven central. Furthermore, I also have increased the version to 0.2.1 to avoid maven caching problems. However, both 0.2.0 and 0.2.1 should work fine.

Thanks!

btw. I think I have met you in person at droidcon 2015 in Berlin after your presentation with Giulio and the other guys from Rheinfabrik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants