Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate outgoing AS objects #681

Closed
silverbucket opened this issue Feb 10, 2022 · 1 comment · Fixed by #684
Closed

Validate outgoing AS objects #681

silverbucket opened this issue Feb 10, 2022 · 1 comment · Fixed by #684
Assignees
Labels
info:breaking-change package:core Issues related to Core Sockethub package package:irc2as Issues related to IRC2AS package:schemas Issues related to Schemas type:bug type:technical-debt

Comments

@silverbucket
Copy link
Member

Currently outgoing AS objects (those generated by irc2as specifically) are not being validated against the sockethub schemas. This means we can easily have inconsistencies with objects sent from sockethub to the client as we continue to improve and increase validation checks with object sent from the client to sockethub.

This was noticed when addressing #679 (irc2as generated AS object with an invalid actor type), and was the start of a larger code overhaul that I'm working on now.

@silverbucket silverbucket added info:breaking-change package:core Issues related to Core Sockethub package package:irc2as Issues related to IRC2AS package:schemas Issues related to Schemas type:bug type:technical-debt labels Feb 10, 2022
@silverbucket silverbucket added this to the Hyperchannel Alpha milestone Feb 10, 2022
@silverbucket silverbucket self-assigned this Feb 10, 2022
@raucao
Copy link
Contributor

raucao commented Feb 19, 2022

Sorry, just found this in the logs, but don't know from what it was:

  sockethub:validate:oJyy2NISvyXrdPA_AAAp applying schema validation for message +0ms
  sockethub:middleware:message Error: /target: must have required property 'type'
  sockethub:middleware:message     at Array.<anonymous> (/home/basti/src/sockethub/sockethub/packages/sockethub/dist/middleware/validate.js:60:22)

@raucao raucao reopened this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:breaking-change package:core Issues related to Core Sockethub package package:irc2as Issues related to IRC2AS package:schemas Issues related to Schemas type:bug type:technical-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants