-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use a custom path #95
Comments
The trailing https://github.com/socketio/engine.io/blob/master/lib/server.js#L449 I wonder why it doesn't work on your environment. What versions of client and server do you use? |
I use the socket.io client https://github.com/socketio/socket.io-client-java which is based on your engine. |
In that case, it'd be the easiest to fix your server since it's difficult to do this library. |
Closed due to inactivity, please reopen if needed. |
what was the problem to delete this / in one place. It really makes a lot of problems. What if a person doesnt have access to backend. This / is useless, if a user needs it he can add it without your checks |
When setting a custom path via the options, the request always contains an extra trailing / in the path.
will lead to the following request
http://myserver/bin/engine.io/?=&EIO=3&transport=polling
which is not supported on my server.
This code explicitly adds the trailing /:
engine.io-client-java/src/main/java/io/socket/engineio/client/Socket.java
Line 202 in 17dc5b4
Is there any specific reason for that ? Can we consider this as a bug ? I can do a PR, change is easy but impact might be huge.
The text was updated successfully, but these errors were encountered: