Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component.json? #289

Closed
markreg opened this issue Apr 15, 2014 · 3 comments
Closed

Add component.json? #289

markreg opened this issue Apr 15, 2014 · 3 comments

Comments

@markreg
Copy link

markreg commented Apr 15, 2014

I believe the repo had a component.json file a while back. Was there a reason for removing it?

@markreg
Copy link
Author

markreg commented Apr 16, 2014

Should I make a pull request or was it left out intentionally?

@eivindfjeldstad
Copy link

The problem is that the code base has been split into several modules, most maintained by @get, none of which has a component.json. The one in this repo was outdated for months before being removed. I assume it means component will no longer be supported, but i afaik @guille hasn't confirmed this yet :)

@rauchg
Copy link
Contributor

rauchg commented Apr 16, 2014

engine.io-client, like many other modules in the JavaScript ecosystem, runs on both the Node.JS and browser environments.

We already have a manifest file that describes the module name, its version, its description, its dependencies… I've come to realize that duplicating all of that into a new file called component.json is not the best idea.

Two things can address your particular need:

  1. component(1) embraces the possibility of leveraging NPM modules without having authors add a new manifest
  2. you compile package.json down to component.json programmatically

Ultimately, since with browserify this module works fine, the second option is totally technically viable if the component maintainers are not interested in the first one.

I think it'd be unfair for me to maintain component.json and keep out bower.json (like I have in the past). Instead, I take the (what I consider) sane approach of not duplicating manifests in source control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants