Server should not clear writeBuffer in every flush #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used SourceTree for rebasing with master but Github Mac client for commit. So in this pull request I see last commit changes also, I think this is related to using different clients for committing and rebasing. |
|
Please rebase against master |
|
Done. |
| this.writeBufferLengths.push(writeBufferObject.length); | ||
| this.emit('flush', writeBufferObject); | ||
| this.server.emit('flush', this, writeBufferObject); | ||
| this.transport.send(writeBufferObject); |
There was a problem hiding this comment.
It's really hard for me to follow the logic here :\ Variable names are too long as well.
There was a problem hiding this comment.
Oh! Ok, So please let me to change the variable names.
|
Ok. Please check the code again. |
| var msg = "boo"; | ||
|
|
||
| socket.on('drain', function() { | ||
| expect(socket.writeBuffer.length).not.to.be(0); |
|
Ops, Excuse me for that. Fixed. |
Slow upgrade should not take down server.
add new test for clean writeBuffer in nextTick.
|
New commits added for issue #89. |
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
fix "TypeError: Object #<Object> has no method 'global'"
darrachequesne
added a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #59