Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .disconnect() #32

Closed
rauchg opened this issue Aug 31, 2010 · 4 comments
Closed

Implement .disconnect() #32

rauchg opened this issue Aug 31, 2010 · 4 comments

Comments

@rauchg
Copy link
Contributor

rauchg commented Aug 31, 2010

It will

  • close the connections
  • send the server a special disconnection notice (volatile)
@mbrevoort
Copy link

Guillermo,

What's the status of this issue. I see that there is a disconnect now implemented by each transport. When I call it thought, it doesn't seem to express my intent to cease the socket.io "connection".

For example, when I call disconnect on a websocket connection in Chrome, it does disconnect but then reconnects and downgrades to xhr-polling. I assume it doesn't really that I initiated the disconnect, caught the disconnect event and then decided to downgrade. In Firefox I see the same behavior with the flashsocket but it degrades to xhr-multipart.

Is this within the scope of this issue?

@philtomson
Copy link

Does disconnect() remove all events related to the socket as well?

@3rd-Eden
Copy link
Contributor

No, disconnect does not remove any events.

@philtomson
Copy link

...it would be nice if it did.

We're reconnecting later and ending up with duplicate events.

@rauchg rauchg closed this as completed Jun 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants