Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: channel.split is not a function #73

Closed
ghost opened this issue Oct 13, 2015 · 10 comments
Closed

TypeError: channel.split is not a function #73

ghost opened this issue Oct 13, 2015 · 10 comments

Comments

@ghost
Copy link

ghost commented Oct 13, 2015

in index.js,

var pieces = channel.split('#'); change this bit of code into this
var pieces = channel.toString().split('#');

and it works.

@ghost ghost closed this as completed Oct 13, 2015
@sgarbesi
Copy link

@serohh This was never fixed/released? I'm getting the same error.

@noamtz
Copy link

noamtz commented Nov 19, 2015

I'm using socket.io-redis 0.1.4 and i'm getting the same error too.

@barisusakli
Copy link
Contributor

Looks like it was fixed but never published

c07b3bd#diff-168726dbe96b3ce427e7fedce31bb0bc

@rauchg

@aPoCoMiLogin
Copy link

@noamtz, @sgarbesi Well latest changes are not tagged, so if you want latest fixes you have to provide socketio/socket.io-redis#master or socketio/socket.io-redis#7d7814920ed57c9c500a56be019e893413279b75 instead of version, then you'll get it fixed.

package.json:

"socket.io-redis": "socketio/socket.io-redis#master"

@irakliy81
Copy link

the above fix works - but is there a plan to tag the latest changes as an actual release? Thanks!

@rauchg
Copy link
Contributor

rauchg commented Nov 28, 2015

Yep. A big release of socket.io-redis is coming in the next week.

@aPoCoMiLogin
Copy link

Sounds good, will test it later, now have to stick to that workaround.

@jdegger
Copy link

jdegger commented Dec 3, 2015

@rauchg Any news on when you're going to release?

@aPoCoMiLogin
Copy link

@jdegger even if they release latest changes, there are still issues which probalby you will face it: #78 just use version 0.1.3

@jdegger
Copy link

jdegger commented Dec 4, 2015

Alright thanks for letting me know @aPoCoMiLogin

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants