Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io is 1.3.6 but the socket.io.client is still 1.3.5? #2182

Closed
chitchatrobot opened this issue Jul 22, 2015 · 2 comments
Closed

socket.io is 1.3.6 but the socket.io.client is still 1.3.5? #2182

chitchatrobot opened this issue Jul 22, 2015 · 2 comments

Comments

@chitchatrobot
Copy link

0 passing (14ms)
1 failing

  1. socket.io should be the same version as client:
    Error: expected '1.3.6' to equal '1.3.5'

I am using node.js v0.12.7 and I am running the test packaged with socket.io,
looks like the sockcet.io.client version does not match.
When I look at the package.json.
The "dependencies"
"socket.io-client": "automattic/socket.io-client#ba31817",

Why is this not specifying just "1.3.6"?

@danorton
Copy link

danorton commented Aug 1, 2015

Let me know if this patch fixes it for you.

  1. patch < socket.io.patch
  2. npm install
  3. make test
diff --git a/package.json b/package.json
index f73e473..3117a5b 100644
--- a/package.json
+++ b/package.json
@@ -23,7 +23,7 @@
   "dependencies": {
     "engine.io": "automattic/engine.io#ab2bd0",
     "socket.io-parser": "2.2.4",
-    "socket.io-client": "automattic/socket.io-client#ba31817",
+    "socket.io-client": "automattic/socket.io-client#1659122",
     "socket.io-adapter": "automattic/socket.io-adapter#de5cba",
     "has-binary": "0.1.6",
     "debug": "2.1.3"

@chitchatrobot
Copy link
Author

Hi socket-io.client version 1.3.6 now, and it resolved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@danorton @chitchatrobot and others