Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update engine.io version to 1.5.4 #2245

Closed
vsharmaGit opened this issue Sep 14, 2015 · 9 comments
Closed

update engine.io version to 1.5.4 #2245

vsharmaGit opened this issue Sep 14, 2015 · 9 comments

Comments

@vsharmaGit
Copy link

engine.io-client has resolved a dependency which was retrieving xmlhttprequest from Github. socket.io 1.3.6 relies on engine.io version 1.5.2. please update engine.io version

@nicofff
Copy link

nicofff commented Sep 14, 2015

+1

@torvalamo
Copy link

It is updated on github, so if you do

npm install git+https://github.com/socketio/socket.io

you've got it.

However there is one bug, which is that engine.io complains that module base64id isn't found. So you need to

npm install base64id

separately, and you're good to go. At least I haven't seen anything bad yet apart from that.

@vsharmaGit
Copy link
Author

unfortunately, we don't have GIT installed in our build environment as well this doesn't solve our issue since socket.io is a dependency for browser-sync and karma.

@maxscott
Copy link

+1 if you have a direct dependency on socket.io this is enough, but for everyone else, it means forking your real dependenc(ies) and bumping the socket.io reference... I'd love to see a patch release resolving this.

@justerhan
Copy link

@torvalamo 's suggestion didn't work for me :( . Very annoying, especially regarding @maxwerr 's point. I used npm's built-in shrinkwrap command (https://docs.npmjs.com/cli/shrinkwrap) to get this working in node v4.0.0. The shrinkwrap command allows you to bump the version number in your dependant packages without having to fork them. You can run the failed npm install command and still generate the proper npm-shrinkwrap.json file then bump the engine.io version. Pretty handy in these kind of situations.

@maxscott
Copy link

@BountyX that's really smart. great workaround until this passes tests and gets released..

@jldec
Copy link

jldec commented Sep 21, 2015

appears to be fixed in socket.io v1.3.7

@mikermcneil
Copy link

@jldec 👍 @rauchg published 1.3.7 yesterday which depends on engine@1.5.4

@vsharmaGit I imagine this can be closed :)

@vsharmaGit
Copy link
Author

Awesome...thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@torvalamo @mikermcneil @nicofff @jldec @justerhan @maxscott @vsharmaGit and others