Merge pull request #32 from mavenugo/master

Added Disconnected Notification to the clients

client.go

@@ -88,6 +88,8 @@ type NotificationHandler interface {
 
 	// RFC 7047 section 4.1.11 Echo Notification
 	Echo([]interface{})
+
+	Disconnected(*OvsdbClient)
 }
 
 // RFC 7047 : Section 4.1.6 : Echo
@@ -174,9 +176,9 @@ func (ovs OvsdbClient) Transact(database string, operation ...Operation) ([]Oper
 	args := NewTransactArgs(database, operation...)
 	err := ovs.rpcClient.Call("transact", args, &reply)
 	if err != nil {
-		log.Fatal("transact failure", err)
+		return nil, err
 	}
-	return reply, err
+	return reply, nil
 }
 
 // Convenience method to monitor every table/column
@@ -231,7 +233,14 @@ func getTableUpdatesFromRawUnmarshal(raw map[string]map[string]RowUpdate) TableU
 }
 
 func clearConnection(c *rpc2.Client) {
-	connections[c] = nil
+	if _, ok := connections[c]; ok {
+		for _, handler := range connections[c].handlers {
+			if handler != nil {
+				handler.Disconnected(connections[c])
+			}
+		}
+	}
+	delete(connections, c)
 }
 
 func handleDisconnectNotification(c *rpc2.Client) {

example/play_with_ovs.go

@@ -28,6 +28,7 @@ func play(ovs *libovsdb.OvsdbClient) {
 							name := newRow.Fields["name"].(string)
 							if name == "stop" {
 								fmt.Println("Bridge stop detected : ", uuid)
+								ovs.Disconnect()
 								quit <- true
 							}
 						}
@@ -160,3 +161,5 @@ func (n Notifier) Stolen([]interface{}) {
 }
 func (n Notifier) Echo([]interface{}) {
 }
+func (n Notifier) Disconnected(client *libovsdb.OvsdbClient) {
+}

ovs_integration_test.go

@@ -294,6 +294,8 @@ func (n Notifier) Stolen([]interface{}) {
 func (n Notifier) Echo([]interface{}) {
 	n.echoChan <- true
 }
+func (n Notifier) Disconnected(client *OvsdbClient) {
+}
 
 func TestDBSchemaValidation(t *testing.T) {