encoding_test: Compare unmarshalled set in maps #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golang's maps do not have any order guarantee when copying or iterating. That's not usually a problem when you compare their JSON representations because assert.JSONEq uses reflect.DeepEqual which takes this into account However, in this case, the unmarshalled represetation of the map is actually a slice, whose ordering does matter. Therefore, a more robust comparison would be to use assert.ElementsMatch() Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang's maps do not have any order guarantee when copying or iterating.
That's not usually a problem when you compare their JSON representations
because assert.JSONEq uses reflect.DeepEqual which takes this into
account
However, in this case, the unmarshalled represetation of the map is
actually a slice, whose ordering does matter.
Therefore, a more robust comparison would be to use
assert.ElementsMatch()
Fixes #73
Signed-off-by: Adrian Moreno amorenoz@redhat.com