Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapper access in the scheduler #106

Merged
merged 2 commits into from Jul 16, 2021
Merged

Fix wrapper access in the scheduler #106

merged 2 commits into from Jul 16, 2021

Conversation

bryanp
Copy link

@bryanp bryanp commented Mar 19, 2021

Description

I've noticed this error lately in my recent use of async-io:

/Users/bryanp/.gem/ruby/3.0.0/gems/async-1.28.9/lib/async/scheduler.rb:74:in `ensure in io_wait': undefined method `reactor=' for nil:NilClass (NoMethodError)
	from /Users/bryanp/.gem/ruby/3.0.0/gems/async-1.28.9/lib/async/scheduler.rb:74:in `io_wait'
	from /Users/bryanp/.rubies/ruby-3.0.0/lib/ruby/3.0.0/socket.rb:304:in `__sendmsg'
	from /Users/bryanp/.rubies/ruby-3.0.0/lib/ruby/3.0.0/socket.rb:304:in `sendmsg'

It's been quite tough to reproduce on demand but happens enough I thought it warranted bringing up for discussion.

Types of Changes

  • Bug fix.

Testing

  • I tested my changes locally.

@bryanp bryanp requested a review from ioquatix March 19, 2021 16:11
@ioquatix ioquatix changed the base branch from master to stable-v1 July 16, 2021 05:21
@ioquatix
Copy link
Member

We have completely removed the need for this in the current implementation. For the current stable-v1 branch, this may still be applicable.

@ioquatix ioquatix merged commit 122cbdf into stable-v1 Jul 16, 2021
@ioquatix ioquatix deleted the fix/wrapper-access branch July 16, 2021 05:22
@ioquatix
Copy link
Member

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants