Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the 'virtual' command be changing the Console.logger log level? #222

Closed
jakeonfire opened this issue Feb 7, 2024 · 4 comments
Closed

Comments

@jakeonfire
Copy link

jakeonfire commented Feb 7, 2024

ENV['CONSOLE_LEVEL'] = 'debug'

debug is way too noisy in production. (is there a good way to override the Console.logger log level in a rails app?)

@jakeonfire
Copy link
Author

adding

Console.logger.level = Console::Logger::LEVELS[:warn]

to falcon.rb works for now. i still don't think it should default to debug, however.

@jakeonfire jakeonfire changed the title Should the virtual command be changing the Console.logger log level? Should the 'virtual' command be changing the Console.logger log level? Feb 8, 2024
@ioquatix
Copy link
Member

ioquatix commented Feb 8, 2024

Yeah, that's a fair point, not sure what I was thinking at the time - I'll reconsider it.

@jakeonfire
Copy link
Author

even changing that line to ENV['CONSOLE_LEVEL'] ||= 'debug' would make it easier to override imo if you have a reason for a default.

@ioquatix
Copy link
Member

This is fixed and will be released in the next version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants