Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document exported globals #113

Closed
trevnorris opened this issue Jan 17, 2023 · 3 comments
Closed

Document exported globals #113

trevnorris opened this issue Jan 17, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@trevnorris
Copy link
Contributor

Currently, socket exports window.__args and window.__ipc. If these are going to be considered public then we should document them.

Ref: #14
@trevnorris trevnorris added the documentation Improvements or additions to documentation label Jan 17, 2023
@chicoxyzzy
Copy link
Member

chicoxyzzy commented Jan 31, 2023 •
edited

We can try to move these two globals to the "native" Socket modules #126

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Jan 31, 2023 •
edited

window.__ipc.postMessage code doesn't depend on any Socket arguments, so it could go to the socket:ipc's exported postMessage function

Most of window.__args values could be written to some module with exported constants. It seems that only window.__args.index can't be shared between all the windows, because it's a window id

This was referenced Jan 31, 2023
Merged
Merged
@trevnorris
Copy link
Contributor Author

Excellent. Looks like this means there won't be any global exports. I'll close this issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trevnorris @chicoxyzzy