Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

title field in the ssc.config doesn't set window title on app start #20

Closed
chicoxyzzy opened this issue Oct 20, 2022 · 4 comments
Closed

title field in the ssc.config doesn't set window title on app start #20

chicoxyzzy opened this issue Oct 20, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@chicoxyzzy
Copy link
Member

No description provided.

@chicoxyzzy chicoxyzzy added the bug Something isn't working label Oct 20, 2022
@heapwolf
Copy link
Member

I think a while back I decided it should be api only. can we remove it from the config?

@chicoxyzzy
Copy link
Member Author

I think that either all of height, weight and title should work from config or all of them should be API only. It feels more practical to me to be able to set title via config

@jwerle
Copy link
Member

jwerle commented Oct 28, 2022

@heapwolf I think we should allow the window title to be set from config. WDYT ?

@chicoxyzzy
Copy link
Member Author

title is window.document.title (and according <title> element now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heapwolf @jwerle @chicoxyzzy