Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to detect Chromium based browsers #642

Open
Ganges29 opened this issue Nov 28, 2023 · 1 comment
Open

Unable to detect Chromium based browsers #642

Ganges29 opened this issue Nov 28, 2023 · 1 comment

Comments

@Ganges29
Copy link

Ganges29 commented Nov 28, 2023

Hi Team,

The code for isChromPackagedApp at line

, isChromePackagedApp = global.chrome && global.chrome.app && global.chrome.app.runtime

does not seem to work as expected.
It is not distinguishing between different browsers, as the last value (runtime) in the condition global.chrome.app.runtime is not existing.

Now that chromium based browsers planning to remove unload completely -
https://developer.chrome.com/articles/deprecating-unload/ , there is a chance that some functionality might not work as desired.

Can someone please take a look?

Thanks in advance!!

@weeraravee
Copy link

I have the same concern. Can any maintainer respond here please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants