Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floods of Cannot read property 'close' of null on timeouts occurring occasionally #197

Closed
prawnsalad opened this issue Apr 11, 2016 · 7 comments

Comments

@prawnsalad
Copy link

TypeError: Cannot read property 'close' of null
    at WebSocketReceiver.heartbeat_timeout (/root/transport/node_modules/sockjs/lib/trans-websocket.js:157:26)
    at null._onTimeout (/root/transport/node_modules/sockjs/lib/trans-websocket.js:75:24)
    at Timer.listOnTimeout (timers.js:92:15)
@tmds
Copy link

tmds commented Apr 11, 2016

Probably related to #185

@tmds
Copy link

tmds commented Apr 11, 2016

What version of sockjs-node are you using?

@prawnsalad
Copy link
Author

Using 0.3.16. Looks like it might be the same issue as you mentioned

@domderen
Copy link

I have the same problem with sockjs@0.3.16 used inside webpack-dev-server. Stack trace:

/lightning-ui/node_modules/webpack-dev-server/node_modules/sockjs/lib/trans-websocket.js:157
      return this.session.close(3000, 'No response from heartbeat');
                         ^

TypeError: Cannot read property 'close' of null
    at WebSocketReceiver.heartbeat_timeout (/lightning-ui/node_modules/webpack-dev-server/node_modules/sockjs/lib/trans-websocket.js:157:26)
    at null._onTimeout (/lightning-ui/node_modules/webpack-dev-server/node_modules/sockjs/lib/trans-websocket.js:75:24)
    at Timer.listOnTimeout (timers.js:92:15)

@prewk
Copy link

prewk commented Apr 29, 2016

This is becoming a real issue for us, on large projects the dev server can be pretty slow to restart. Do you have any ideas? edit: Oops, I should probably continue in #185

@brycekahle
Copy link
Contributor

Fixed by #179

@brycekahle
Copy link
Contributor

Released in 0.3.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants