Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract check level filters #2054

Open
tombaeyens opened this issue Apr 16, 2024 · 2 comments
Open

Contract check level filters #2054

tombaeyens opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
contract Data contracts

Comments

@tombaeyens
Copy link
Contributor

No description provided.

@tombaeyens tombaeyens added the contract Data contracts label Apr 16, 2024
@tombaeyens tombaeyens self-assigned this Apr 16, 2024
@tools-soda
Copy link

SAS-3247

@tombaeyens
Copy link
Contributor Author

tombaeyens commented Jun 28, 2024

See this section in the code

# TODO explain filter_expression_sql, default filter and named filters

        # TODO explain filter_expression_sql, default filter and named filters
        # filter name must part of the identity of the metrics
        #   - no filter part if no filter is specified
        #   - "default" is the filter name if there is only a default specified with "filter_expression_sql"
        #   - {filter_name} if a filter is activated from a named map of filters
        self.filter: str | None = None

        self.filter_sql: str | None = None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract Data contracts
Projects
Status: In Progress
Development

No branches or pull requests

2 participants