Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

env_var should be optional when a user is not passing a yaml file #300

Closed
chriscardillo opened this issue Mar 15, 2021 · 4 comments
Closed
Labels
enhancement New feature or request soda-sql

Comments

@chriscardillo
Copy link

Is your feature request related to a problem? Please describe.
Users utilizing the warehouse_yml_dict option in ScanBuilder should not be constrained to have to use the env_var parameter. If they're using a dict, they're most likely pulling in sensitive information from the environment anyway.

Describe the solution you'd like
Two options include:

  • If the dict is used instead of a yaml, Soda's parser should not run any kind of env_var checks in on the user input.
  • Support SQLAlchemy connection objects, where the user can provide you most/all warehouse details Soda requires.

Additional context
N/A

Soda SQL Version: 2.0.0b21

@chriscardillo chriscardillo added enhancement New feature or request soda-sql labels Mar 15, 2021
@tombaeyens
Copy link
Contributor

I think that usage of env_var(...) should always be optional. Both in YAML as well as dict.

The way you phrase it it looks like env_var(...) is required. Is that what you experienced?

Would ensuring the env_var resolving is optional, solve your problem?

@chriscardillo
Copy link
Author

Yes, it appears that env_var(...) is currently required for anything Soda considers a credential (e.g. a password) and raises an error if a credential field is used without env_var(...).

@tombaeyens
Copy link
Contributor

I m changing it so that env_var is not required.

@vijaykiran
Copy link
Contributor

Fixed!

@vijaykiran vijaykiran transferred this issue from sodadata/soda-core Mar 22, 2022
@vijaykiran vijaykiran transferred this issue from sodadata/soda-core Mar 22, 2022
@vijaykiran vijaykiran transferred this issue from sodadata/soda-core Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request soda-sql
Projects
None yet
Development

No branches or pull requests

3 participants