Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-unified titlebars don't look correct #91

Closed
electricduck opened this issue Nov 7, 2023 · 4 comments
Closed

Non-unified titlebars don't look correct #91

electricduck opened this issue Nov 7, 2023 · 4 comments
Labels
5.1 Varri Tasks relating to Sodalite 5.1 Varri 6 Kutai Tasks relating to Sodalite 6 Kutai 👀 help needed Think you could help? 🐞 issue Something is wrong

Comments

@electricduck
Copy link
Member

electricduck commented Nov 7, 2023

image

At some point, titlebars have changed and now they are always falling back to their light theme as well as being abnormally large.

@electricduck electricduck added the 🐞 issue Something is wrong label Nov 7, 2023
@electricduck
Copy link
Member Author

electricduck commented Nov 8, 2023

Hm, elementaryOS doesn't exhibit this behaviour, so its clearly not supposed to happen.

image
GParted on Sodalite 6

image
GParted on elementaryOS 7.1

image
On elementaryOS 7.1, Darkbar can also style titlebars still, whereas it no longer works in Sodalite

@electricduck electricduck changed the title Non-unified titlebars don't follow system theme Non-unified titlebars are broken Nov 8, 2023
@electricduck electricduck added the 👀 help needed Think you could help? label Nov 8, 2023
@electricduck electricduck pinned this issue Nov 8, 2023
@electricduck electricduck changed the title Non-unified titlebars are broken Non-unified titlebars don't look correct Nov 8, 2023
@electricduck
Copy link
Member Author

electricduck commented Nov 8, 2023

At a loss here.

Out of frustration, did try installing a custom theme in Sodalite and it seems to apply properly for all apps, so can only assume this is an issue with elementary's stylesheets themes...

image

Not sure if this is a problem with the theme running on Mutter 45, since elementaryOS 7.1 uses 42 (and there was previously a bug with 44: elementary/stylesheet#1253). Apart from that, elementaryOS 7.1 and Sodalite 6 has practically identical configurations when it comes to theming.

@electricduck electricduck added 5.1 Varri Tasks relating to Sodalite 5.1 Varri 6 Kutai Tasks relating to Sodalite 6 Kutai labels Nov 8, 2023
@electricduck
Copy link
Member Author

electricduck commented Nov 10, 2023

Seems as if Ultramarine 38 Pantheon does this too, so it's not something we've broken then.

image
Pantheon on Ultramarine 38

Opened an issue over at elementary/stylesheet#1269.

@electricduck
Copy link
Member Author

Fixed with stylesheet 7.3.0.

@electricduck electricduck unpinned this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.1 Varri Tasks relating to Sodalite 5.1 Varri 6 Kutai Tasks relating to Sodalite 6 Kutai 👀 help needed Think you could help? 🐞 issue Something is wrong
Projects
Status: 👍 Done
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant