-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyfiles does not fail #28
Comments
ok, this fails |
That's very strange. I need to look into that. |
I'm not entirely sure where to install things. Is C: the right place? |
The behavior in this case is not easy to define. If it has no icon, it may go to C: but MorphOS also has SYS:Tools/Installer.info. |
@sodero I don't want to open an issue, what do you think about stripping the exe? |
I doesn't work on AROS, strip seems to break the exe, that's why it's not done in the Makefile. Perhaps dist/Makefile is a good place for this. An exception for AROS is needed. |
I see. Since MorphOS 3.10 there's better debug support in LogTool, so we may keep the symbols in alpha. |
Ok, now I know what's happening here. In the first case (build/Installer "dist/InstallerLG installer"), the script is executed from the top dir (where the CHANGELOG is located). Due to this, the Installer binary cannot be found and the file operation fails silently, it simply ignores the error and continues. This "feature" is required by some scripts and it's how the CBM Installer and the MorphOS installer work. In the second case, the binary is found and then copy will fail due to the lock. There's quite a few "features" like this one and you can turn most of them of with an (set @strict 1) at the top of the script (or anywhere really, you can enable sloppy mode again using (set @strict 0) if required). I enabled strict mode in the installer script so now "build/Installer dist/InstallerLG installer" will fail like it should. |
lock C: on
build/Installer "dist/InstallerLG installer"
should fail...
The text was updated successfully, but these errors were encountered: