Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyfiles does not fail #28

Closed
polluks opened this issue Oct 12, 2018 · 9 comments
Closed

copyfiles does not fail #28

polluks opened this issue Oct 12, 2018 · 9 comments
Labels

Comments

@polluks
Copy link
Collaborator

polluks commented Oct 12, 2018

lock C: on
build/Installer "dist/InstallerLG installer"
should fail...

@sodero sodero added the bug label Oct 12, 2018
@polluks
Copy link
Collaborator Author

polluks commented Oct 12, 2018

ok, this fails
cd dist
Installer "/dist/InstallerLG installer"

@sodero
Copy link
Owner

sodero commented Oct 13, 2018

That's very strange. I need to look into that.

@polluks
Copy link
Collaborator Author

polluks commented Oct 13, 2018

version
Version 1.40 is MOSSYS:C/Installer!
BTW version C:foo is always version MOSSYS:C/foo.

@sodero
Copy link
Owner

sodero commented Oct 13, 2018

I'm not entirely sure where to install things. Is C: the right place?

@polluks
Copy link
Collaborator Author

polluks commented Oct 13, 2018

The behavior in this case is not easy to define. If it has no icon, it may go to C: but MorphOS also has SYS:Tools/Installer.info.

@polluks
Copy link
Collaborator Author

polluks commented Oct 14, 2018

@sodero I don't want to open an issue, what do you think about stripping the exe?

@sodero
Copy link
Owner

sodero commented Oct 14, 2018

I doesn't work on AROS, strip seems to break the exe, that's why it's not done in the Makefile. Perhaps dist/Makefile is a good place for this. An exception for AROS is needed.

@polluks
Copy link
Collaborator Author

polluks commented Oct 15, 2018

I see. Since MorphOS 3.10 there's better debug support in LogTool, so we may keep the symbols in alpha.

@sodero
Copy link
Owner

sodero commented Oct 24, 2018

Ok, now I know what's happening here.

In the first case (build/Installer "dist/InstallerLG installer"), the script is executed from the top dir (where the CHANGELOG is located). Due to this, the Installer binary cannot be found and the file operation fails silently, it simply ignores the error and continues. This "feature" is required by some scripts and it's how the CBM Installer and the MorphOS installer work. In the second case, the binary is found and then copy will fail due to the lock.

There's quite a few "features" like this one and you can turn most of them of with an (set @strict 1) at the top of the script (or anywhere really, you can enable sloppy mode again using (set @strict 0) if required).

I enabled strict mode in the installer script so now "build/Installer dist/InstallerLG installer" will fail like it should.

@sodero sodero closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants