Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCFTPd: syntax error #37

Closed
polluks opened this issue Sep 8, 2019 · 5 comments
Closed

RCFTPd: syntax error #37

polluks opened this issue Sep 8, 2019 · 5 comments

Comments

@polluks
Copy link
Collaborator

polluks commented Sep 8, 2019

Line 757
(if (>= @user-Level 2)(confirm))
http://aminet.net/package/comm/tcp/rc-ftpd

@sodero
Copy link
Owner

sodero commented Sep 9, 2019

Thanks! I'll have a look.

@sodero
Copy link
Owner

sodero commented Sep 9, 2019

Fixed, but not commited yet, the tree is in a bit of a mess.

The script construct is strange though. It's possible to achieve the exact same thing with just "(confirm 2)" or "(confirm)". And "(if (>= @user-Level 1) (confirm))" (which is used in other places in the script) won't result in a confirmation since the default threshold of confirm is 2 (hence "(confirm 2)" == "(confirm)". What the author intend to do is probably "(confirm 1)".

Nevertheless, the code exists, so we should support it. Even though it might not do exactly what the author wanted.

@sodero
Copy link
Owner

sodero commented Sep 9, 2019

Fixed in c4f7f32

@sodero sodero closed this as completed Sep 9, 2019
@sodero
Copy link
Owner

sodero commented Sep 9, 2019

Nope. I messed up. Need to try again.

@sodero sodero reopened this Sep 9, 2019
@sodero
Copy link
Owner

sodero commented Sep 9, 2019

Ok, now it's better.

@sodero sodero closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants