New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why using SOFA_DEPRECATED_HEADER instead of SOFA_HEADER_DEPRECATED for consistency ? #84

Open

hugtalbot opened this issue Jan 6, 2023 · 1 comment

Assignees

Contributor

hugtalbot commented Jan 6, 2023 •

edited

Loading

We have SOFA_DEPRECATED_HEADER and SOFA_DISABLED_HEADER
while we have SOFA_ATTRIBUTE_DEPRECATED and SOFA_ATTRIBUTE_DISABLED.

Why not having coherency and defining SOFA_HEADER_DEPRECATED and SOFA_HEADER_DISABLED @alxbilger @damienmarchal ?

Doc page: https://github.com/sofa-framework/doc/blob/master/50_Contributing_to_SOFA/45_Lifecycle_mechanisms.md

The text was updated successfully, but these errors were encountered:

hugtalbot self-assigned this

Contributor

alxbilger commented Jan 6, 2023

Indeed, it would be more consistent.
But don't forget SOFA_DEPRECATED_HEADER_NOT_REPLACED and SOFA_DISABLED_HEADER_NOT_REPLACED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment