Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

如何基于 ConfigItem 扩展自定义的配置项？ #101

Closed
zhaojigang opened this issue Oct 14, 2018 · 2 comments
Closed

如何基于 ConfigItem 扩展自定义的配置项？ #101

zhaojigang opened this issue Oct 14, 2018 · 2 comments
Assignees
@dbl-x
Labels
req:todo will be fix or implement later

Comments

@zhaojigang
Copy link
Contributor

Your question

image

  1. 假设现在想增加一个自定义配置项 NETTY_TCP_NODELAY，由于 ConfigItem 是一个 enum 类，无法继承，这时候我们应该怎么添加一个自定义的的扩展项呢？

  2. ConfigItem 和 Configs 类冗余，建议去掉 ConfigItem 类，
    image

ConfigContainer中的第二个参数用 Configs 中的String 来填充。

  • SOFABolt version: 1.5.1
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:
@dbl-x dbl-x self-assigned this Oct 18, 2018
@dbl-x dbl-x added the req:todo will be fix or implement later label Oct 18, 2018
@dbl-x
Copy link
Contributor

dbl-x commented Oct 18, 2018

目前这块是无法拓展的，如果需要拓展，需要修改源码。后续会将这个做成可配置。

@dbl-x dbl-x closed this as completed Oct 18, 2018
@dbl-x dbl-x reopened this Oct 18, 2018
@zhaojigang
Copy link
Contributor Author

👌

@dbl-x dbl-x closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbl-x dbl-x

Labels
req:todo will be fix or implement later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbl-x @zhaojigang