Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default connNum of the Url object is 0, resulting in no connection being created #212

Closed
dbl-x opened this issue Dec 31, 2019 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dbl-x
Copy link
Contributor

dbl-x commented Dec 31, 2019

Describe the bug
image

  • the default connNum of Url is 0

image

  • if expectNum == 0 && actualNum == 0,no connection will be created

image

  • in RpcAddressParser, the default value of connNum is 1

Expected behavior

the default connNum of Url must be 1 to keep consistent with RpcAddressParser

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

  • SOFABolt version: all version
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:
@dbl-x dbl-x added the bug Something isn't working label Dec 31, 2019
@dbl-x dbl-x self-assigned this Dec 31, 2019
@dbl-x dbl-x added this to the 1.6.2 release milestone Jul 1, 2020
@dbl-x dbl-x mentioned this issue Jul 7, 2020
@dbl-x dbl-x closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant