Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

SofaBootRpcAutoConfiguration中的configureProcessorMap处理不支持自定义registry #173

Closed
citywalki opened this issue Apr 28, 2019 · 6 comments · Fixed by #183
Closed
Assignees
Milestone

Comments

@citywalki
Copy link

citywalki commented Apr 28, 2019

Your question

在目前的com.alipay.sofa.rpc.boot.SofaBootRpcAutoConfiguration#configureProcessorMap中,是按照系统支持的registry写死的,不支持自定义registry,这违背了sofa-rpc的扩展性

Your scenes

在sofa-boot中使用自定义的registry

Your advice

将现在的RegistryConfigureProcessor改成用protocol的parserFactory,对系统支持的protocol定义parser,对于不支持的protocol提供默认的parser,考虑能否支持自定义注册parser。

@citywalki citywalki changed the title registryConfig不支持自定义registry SofaBootRpcAutoConfiguration中的configureProcessorMap处理不支持自定义registry Apr 28, 2019
@citywalki
Copy link
Author

这事没人管管吗?现在在不加exclude的清空下,都没有办法覆盖这个bean

@khotyn
Copy link
Member

khotyn commented Apr 30, 2019

@leizhiyuan @ujjboy 你们帮忙看下哦。

@JervyShi
Copy link
Member

@iamcyw 可以提个 PR 解决这个问题么?

@citywalki citywalki reopened this Apr 30, 2019
@citywalki
Copy link
Author

@iamcyw 可以提个 PR 解决这个问题么?

或者可以在configureProcessorMap上加入@conditional来支持覆盖这个bean吗?这样的改动是最小的,而且也是一个不错的扩展性方案
我可以做这个事情,但是我想我们能有一个处理的共识可以吗?

@leizhiyuan leizhiyuan added this to the 6.0.1 milestone May 2, 2019
@leizhiyuan
Copy link
Contributor

如果你这边最近需要使用测试,可以通过注解来覆盖,

测试确认可行后,长期的方案,可以提个 PR 来统一解决?这样其他的人就不再需要覆盖了~

@leizhiyuan
Copy link
Contributor

@iamcyw

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants