Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer-TimedAppender thread should set daemon #26

Closed
leizhiyuan opened this issue Jul 9, 2018 · 0 comments
Closed

Tracer-TimedAppender thread should set daemon #26

leizhiyuan opened this issue Jul 9, 2018 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@leizhiyuan
Copy link
Contributor

sofastack/sofa-rpc-boot-projects#69

from the issue, I tested on the local machine

 SofaTracerStatisticReporterManager(final long cycleTime) {
        this.cycleTime = cycleTime;
        this.executor = Executors.newSingleThreadScheduledExecutor(new ThreadFactory() {

            public Thread newThread(Runnable r) {
                final Thread thread = new Thread(r, "Tracer-TimedAppender-"
                                                    + THREAD_NUMBER.incrementAndGet() + "-"
                                                    + cycleTime);
                thread.setDaemon(true);
                return thread;
            }
        });
        start();
    }

this code should modify like this

@guanchao-yang guanchao-yang added the enhancement New feature or request label Jul 9, 2018
@guanchao-yang guanchao-yang added this to the 2.1.2 milestone Jul 9, 2018
@guanchao-yang guanchao-yang added the bug Something isn't working label Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants