Possible bug?

[dmrev]

Line 67 in RateLimit.swift:

// Record execution
dictionary[name] = NSDate()

You record new execution time even if decide to not execute? Is that right?

[soffes]

Yikes! You're right. I'll get this fixed ASAP.

[soffes]

Fixed in 2a319ad. Version 1.1.1 is released with this fix.

[soffes]

Actually, it worked as expected before. Oops.

[dmrev]

You wrong. Think again.
In your original implementation, if you call some block fast enough (time interval between calls < limit), than that block will never be executed after first call.
But if you record execution time only after successful call, block will be executed 1 time per limit. This is rate limit.

[soffes]

With your proposed changed, if you hit it ever half second and set the limit to 1 second, it will only get called once.

[dmrev]

Once per second.

[soffes]

Try the demo app in version 1.2.0. It works as expected, no?

[dmrev]

As YOU expected, yes. As I expected – no.
I expect that when i tap very fast (5 times per second, for example) label text will change once per second. This behaviour i will call "rate limit". Rule: "perform call, but no more often than once at the designated time interval."
But what we have now is "call canceller". Because of rule "cancel call if it happens earlier than necessary".

[dmrev]

However, this is not bug, this is design decision. If you want such behaviour, it's ok.