Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSO PR #3

Merged
merged 7 commits into from Jan 26, 2022
Merged

BSO PR #3

merged 7 commits into from Jan 26, 2022

Conversation

antoinebres
Copy link

J'ai :

  • ajouté un init.py pour pouvoir installer le package.
  • ajouté la possibilité d'envoyer des pdf gzippés (.pdf.gz) sur software_mentions.
  • changé les paramètres de config (data_path -> lmdb_path) et (software_mention_url -> software_mention_host + software_mention_port)

@kermitt2
Copy link
Collaborator

Thank you @antoinebres !

Just one point: The data_path would need to stay data_path because in the normal "biblio-glutton-harvester" scenario this path includes not only the LMDB files taking track of the harvesting, but also the harvested files themselves.

cf ->
https://github.com/softcite/software_mentions_client/blob/master/software_mentions_client/client.py#L227

@antoinebres
Copy link
Author

@kermitt2

@kermitt2
Copy link
Collaborator

Thanks a lot @antoinebres !

@kermitt2 kermitt2 merged commit 91c937f into softcite:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants