Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Number input field is not handle '-' symbol #51

Closed
AregSoft opened this issue Jan 22, 2024 · 0 comments · Fixed by #59
Closed

[Bug]: Number input field is not handle '-' symbol #51

AregSoft opened this issue Jan 22, 2024 · 0 comments · Fixed by #59
Assignees
@AregSoft
Labels
phase / shipped This issue has already been released, and wait for the closing type / bug Something isn't working
Milestone
v2.12.2

Comments

@AregSoft
Copy link
Collaborator

Component

ValidatableNumberInput

Is this a regression?

no

Describe the bug

Only '-' symbol in ValidatableNumberInput becomes valid value.

To Reproduce

  1. Open NumberInput insert of ValidatableInput.
  2. Try to type '-' symbol.
  3. Click outside.

Expected behavior

If in input field we type only '-' or '+' symbols, remove that symbols after click outside.

Screenshots

Sandbox.-.CodeSandbox.-.Google.Chrome.2024-01-22.18-01-12.mp4

Package version

v2.11.2

Desktop

. OS:
. Browser & version:
. Additional Information:

Smartphone

. Device:
. OS:
. Browser & version:
. Additional Information:

Exception or Error

No response

Additional context

No response
@AregSoft AregSoft added type / bug Something isn't working phase / exploring This issue is in discovery phase labels Jan 22, 2024
@hamikhambardzumyan hamikhambardzumyan added this to the v2.12.1 milestone Jan 24, 2024
@AregSoft AregSoft linked a pull request Jan 31, 2024 that will close this issue
fix(ValidatableNumberInput): clear bad values of input #59
Merged
@AregSoft AregSoft added phase / review-needed This issue is done and needs review phase / ready-to-go This issue merged and will be included in the current milestone release and removed phase / exploring This issue is in discovery phase phase / review-needed This issue is done and needs review labels Feb 1, 2024
@hamikhambardzumyan hamikhambardzumyan added phase / shipped This issue has already been released, and wait for the closing and removed phase / ready-to-go This issue merged and will be included in the current milestone release labels Feb 2, 2024
@AregSoft AregSoft closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AregSoft AregSoft

Labels
phase / shipped This issue has already been released, and wait for the closing type / bug Something isn't working
Projects
None yet
Milestone
v2.12.2
Development

Successfully merging a pull request may close this issue.

fix(ValidatableNumberInput): clear bad values of input softconstruct/gene-ui-components
2 participants
@hamikhambardzumyan @AregSoft