Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware cancel consolidation #524

Merged
merged 2 commits into from Apr 20, 2015
Merged

Hardware cancel consolidation #524

merged 2 commits into from Apr 20, 2015

Conversation

sudorandom
Copy link
Contributor

This should resolve #522.

  • HardwareManager.cancel_metal() is removed in favor of HardwareManager.cancel_hardware()
  • HardwareManager.cancel_hardware() now uses SoftLayer_Billing_Item::cancelItem() which (I think) works on most cancelable items.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 769d900 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.61% when pulling 769d900 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling ab50844 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.61% when pulling ab50844 on sudorandom:hardware-cancel into 200787d on softlayer:master.

@sudorandom
Copy link
Contributor Author

@underscorephil Do you know if SoftLayer_Billing_Item::cancelItem() is the method to use that can cancel most things? I know they did a lot of work to consolidate cancellation but it's not obvious in the documentation which one should be used.

@underscorephil
Copy link
Contributor

@sudorandom doing some research to make sure my info is up to date. Will keep you in the loop

@sudorandom
Copy link
Contributor Author

@underscorephil so it looks like SoftLayer_Billing_Item::cancelItem is the universal cancel method. That will likely simplify a lot. I think this change is ready.

@underscorephil
Copy link
Contributor

LGTM

underscorephil added a commit that referenced this pull request Apr 20, 2015
@underscorephil underscorephil merged commit 7fa51cf into softlayer:master Apr 20, 2015
@sudorandom sudorandom deleted the hardware-cancel branch December 4, 2015 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem with hourly bare metal servers immediate cancelation in CLI and manager
4 participants