Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify custom gateway for sending SMS #1

Closed
Amegatron opened this issue Jul 10, 2015 · 2 comments
Closed

Specify custom gateway for sending SMS #1

Amegatron opened this issue Jul 10, 2015 · 2 comments

Comments

@Amegatron
Copy link

Hi!
Pretty nice package, but for me at a glance it lacks opportunity to specify my own custom gateway for sending SMS.
This could be achieved in two ways from user-side:

  1. Specify Gateway class directly in config. In this case the package core should check, whether specified value in config is of predefined gateways (it should have an internal array of supported gateways out of the box and just check whether supplied gateway string is in this array). The problem here is how to specify gateway's credentials.
  2. Have a public Facade method which should be called prior to sending SMS, somthing like this:
$gw = new \App\Sms\MyCustomGateway("my_user_id", "my_secret");
Sms::setGateway($gw);
Sms::send("Code: 4356", "79111234567");

Hope you'll find this issue useful and implement as soon as you have time :)

Good luck and Regards,
Amegatron.

@softon
Copy link
Owner

softon commented Jul 10, 2015

Hi Amegatron,

Its a great idea to have a custom gateway. we will do the needfull.

@softon
Copy link
Owner

softon commented Jul 10, 2015

Latest Release includes Custom Gateway. Pls do provide your suggestion.

Regards

@softon softon closed this as completed Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants