feat: Discover current repository #2
Conversation
| @@ -119,3 +132,17 @@ fn main() { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| fn discover_codeowners() -> Option<PathBuf> { | |||
| let curr_dir = current_dir().unwrap(); | |||
There was a problem hiding this comment.
If possible could we avoid unwrapping?
There was a problem hiding this comment.
Sure thing. Docs say that current_dir() could be Err if (perhaps not comprehensive?)
- Current directory does not exist.
- There are insufficient permissions to access the current directory.
Perhaps desired behavior could be printing something like "Could not confirm working directory. Does it still exist? Is it readable?", then exit 2/some not-yet-taken number. What do you think?
|
|
||
| fn discover_codeowners() -> Option<PathBuf> { | ||
| let curr_dir = current_dir().unwrap(); | ||
| let repo = match Repository::discover(&curr_dir) { |
There was a problem hiding this comment.
I wonder if we should just use std::process::Command with "git rev-parse --show-toplevel" since there's not much heavy git lifting needed here.
How much bigger did adding a crate to perform this a action add?
There was a problem hiding this comment.
Here are some numbers I get:
master branch
# Compilation time
$ rm -rf target/ && time cargo build --release
...
Finished release [optimized] target(s) in 1m 12s
real 1m12.546s
user 3m13.753s
sys 0m3.983s
# Binary size
$ du -h target/release/git-codeowners
1.7M target/release/git-codeownersPR branch
$ rm -rf target/ && time cargo build --release
...
Finished release [optimized] target(s) in 1m 58s
real 1m49.198s
user 6m23.143s
sys 0m19.478s
$ du -h target/release/git-codeowners
2.0M target/release/git-codeownersThanks for encouraging me to measure this. I expect that whatever performance benefit to be had from leveraging git2 is likely not worth doubling the CPU time required to compile. But I'll try using std::process::Command as you described and see what perf difference I can measure.
Repository.discoverto locate the current git repo root, if one existsgit2 is a crate of Rust bindings to libgit2. The git book suggests it's the dominant way to "embed" git-like functionality in apps w/o shelling out to the
gitbinary.Cargo.lock changes are the result of running
cargo buildon this branch, w/ cargo version 1.39.0.Manual tests:
Resolves #3.