Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programs built with 0.4.10 cannot build or run against OpenSSL 1.1.1 #157

Closed
nharward opened this issue Sep 27, 2018 · 7 comments
Closed

Comments

@nharward
Copy link

I updated my system recently and now have OpenSSL 1.1.1, discovering shortly afterward that ghopac no longer works. In addition to getting a runtime linker error from the existing binary, I'm also unable to build against the new version. I get a failure compiling openssl-sys v0.9.17 which states the problem:

This crate is only compatible with OpenSSL 1.0.1, 1.0.2, and 1.1.0, or LibreSSL
2.5 and 2.6.0, but a different version of OpenSSL was found. The build is now
aborting due to this version mismatch.

I will try to create a pull request soon, but I thought I'd submit the issue in case someone can get to it before I can.

@nickelc
Copy link
Contributor

nickelc commented Sep 28, 2018

v0.4.10 builds fine for me with openssl 1.1.1 but i had this issue with reqwest v0.8 and v0.9 fixed the build issues.

@nharward
Copy link
Author

@nickelc is OpenSSL 1.1.1 the only version you have installed on your machine? I just tried to build master (has an updated Cargo.toml) and it works fine, but switching to the 0.4.10 tag still results in the same error for me. I can build locally from master but I'd like to get a clean build from the published crates.

@nickelc
Copy link
Contributor

nickelc commented Sep 28, 2018

oh shit sorry, it was a long day. i totally forgot that the hyper 0.12 stuff is not released yet and master is hyper-tls 0.3.

@nickelc
Copy link
Contributor

nickelc commented Sep 29, 2018

more infos on the issue sfackler/rust-openssl#994

@softprops
Copy link
Owner

Yeah sorry this is such a pain. Is there a newer version of something I could be depending on your help matters?

@nickelc
Copy link
Contributor

nickelc commented Sep 29, 2018

this PR would fix the build issue with openssl 1.1.1

diff --git a/Cargo.toml b/Cargo.toml
index a69e814..11186d5 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -37,3 +37,6 @@ version = "0.1.2"
 [features]
 default = ["tls"]
 tls = ["hyper-tls"]
+
+[patch.crates-io]
+openssl = { git = "https://github.com/ishitatsuyuki/rust-openssl", branch = "0.9.x" }

@softprops
Copy link
Owner

This should be covered now and with option to opt into rust tls https://github.com/softprops/hubcaps/blob/master/Cargo.toml#L43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants