Improve error handling #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency isn’t used anymore, so let’s remove it.
The failure crate appears to be deprecated these days and has drawbacks including incompatibilities with std::error::Error. For users, it might be inconvenient to have to deal with error types that don’t implement std::error::Error. For this reason, this replaces the failure crate entirely. In the library part, thiserror is used instead, which also makes the generation of the error type short and convenient (even taking care of the From implementations), without exposing any thiserror specifics to the user. In the example, anyhow now takes care of printing nicely formatted error messages, including error causes and (if provided with RUST_BACKTRACE=1) an error backtrace.
pluehne
force-pushed
the
improve-error-handling
branch
from
99f1f18
to
e2d506c
Compare
|
@softprops: Thanks for merging my other pull requests. I rebased this one on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
failurecrate appears to be deprecated these days and has drawbacks including incompatibilities withstd::error::Error. For users, it might be inconvenient to have to deal with error types that don’t implementstd::error::Error.For this reason, this replaces the
failurecrate entirely. In the library part,thiserroris used instead, which also makes the generation of the error type short and convenient (even taking care of theFromimplementations), without exposing anythiserrorspecifics to the user.In the example,
anyhownow takes care of printing nicely formatted error messages, including error causes and (if provided withRUST_BACKTRACE=1) an error backtrace.Also, the
error-chaindependency isn’t used anymore, so let’s remove it.