Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI logo in the Service tab #87

Closed
edd-cgfan opened this issue May 1, 2023 · 9 comments
Closed

SPI logo in the Service tab #87

edd-cgfan opened this issue May 1, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@edd-cgfan
Copy link

Hi Clem,

This morning I got the chance to receive the 10A mux from Leipzig-Messegrund again, 105.6 km away, including SPI data.
I thought you might like to know how 2 logos are shown in the Service tab. They occupy too much space.
Is this the intended look?
10A-L-Beatzz-ServicePic
10A-L-PSR-ServicePic

Here is zipped the content of the SPI folder for E01011:
SPI.ZIP

And here is a link to a 1-minute raw file taped this morning:
10A-L raw file

Best regards,
cgfan

@softsyst
Copy link
Owner

softsyst commented May 1, 2023

Hi cgfan,

No idea why the logos in your pictures are so pixelated, usually they are very clear. I have not the possibility to verify this ugly look here. (Edited remark: this is wrong, as cgfan provided the SPI directory content, see below).

I'll try to explain the "intended look". Look here (from your file):

image

The text in the small logos will not be readable even with a microscope. In contrast, the logo in the "Service" tab transports the message of the image. The text is crisp-clear. In this way one gets at least what the useless small logo intents to show.

Unfortunately, most services go the simplest and most boring way to repeat the logo in the slideshow. Probably the cheapest solution, fitting the content. However, some do it better and try at least to use the slideshow to show information. Pictures of the artists, weather info. There would be many possibilities.

Another example, not optimal, but they try at least to show something useful:

image

No unreadable text in the small logo, the large logo shows text, perfectly readable, and the SLS shows one of the mods. Why not? Much better than most of the other crap.

So, nothing will happen here, I hope you got the intent.

Clem

@andimik
Copy link

andimik commented May 2, 2023

I could not see an xml.

Let me guess: Qirx does not know which Logo to be displayed here and uses C0BA2C87.png (112x32)
FFF412FA

instead of A61F8F7C.png (320x240)
A61F8F7C

C0BA2C87.png is the small one.
C0BA2C87

But for me it looks more as an enhancement rather than a bug: Clem, could you please let Qirx look for the 320x240 SPI pic and show it there? Otherwise it breaks the layout as described above.

@softsyst
Copy link
Owner

softsyst commented May 2, 2023

@andimik's suggestion is what is already implemented in the code. The simple search algo looks for an image which is non-quadratic and has a width of 320. If none is found it takes the largest present.

Thanks to @cgfan providing the pictures I copied the SPI he provided into the SPI directory and could test it. It's a non-obvious bug in the software. These pictures and also the ones of "Radio SPR" do not have the usual Dpi (dots per inch) value of 96, but 300. When checking the "Width" property of the BitmapImage, one gets a wrong value, as the "Width" is measured in units of 1/96dpi. This is the reason for the ugly picture display, while all other pictures have 96Dpi, resulting in "Width" to be the same as "PixelWidth" (another property of "BitmapImage").

After a quick correction, the pictures display properly.

image

Clem

@softsyst softsyst added the bug Something isn't working label May 2, 2023
@andimik
Copy link

andimik commented May 2, 2023

as the "Width" is measured in units of 1/96dpi.

Oh, interesting. Thanks for the explanation.

@edd-cgfan
Copy link
Author

Thank you Clem for the explanation and the interesting information about your investigation.

... Much better than most of the other crap.

Yes, unfortunately.
Nevertheless, you made me smile.

cgfan

@andimik
Copy link

andimik commented May 6, 2023

BTW: even "our" mux here in Austria had the same problem. Some pics are 300dpi like Radio Austria.

good example (Antenne Österreich)

Screenshot (405)

bad example (Radio Austria)

49ED1A31
Screenshot (404)

other bad example with Arabella Relax

should be that pic
AC45C97E

but this is used
D1EE01CB

Screenshot (403)

@softsyst
Copy link
Owner

Please someone check it if it's ok now. Thanks

@edd-cgfan
Copy link
Author

Hi Clem,

The 2 above mentioned logos in my initial post look okay now with 4.0.9.

cgfan

@softsyst
Copy link
Owner

Again, many thanks for your very fast response. I close that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants