Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to use two instances in parallel #23

Merged
merged 8 commits into from Jan 11, 2019

Conversation

konsultaner
Copy link
Contributor

I did not open an issue for this feature request.
I want to work with multiple secrets on the same local storage. This is not possible because all meta data get encoded under the same key. Thats why I needed to reparate them. I introduced a encryptionRealm to make it possible.

I added the test and examples. I hope you are ok with this feature. If you merge you need to update the version and build again, because my builds have a wrong version now...

@coveralls
Copy link

coveralls commented Jan 6, 2019

Coverage Status

Coverage increased (+0.4%) to 86.46% when pulling 2ef4862 on konsultaner:master into b318562 on softvar:master.

@konsultaner
Copy link
Contributor Author

I managed it to update the version. So there should be no further commits necessary.

@softvar
Copy link
Owner

softvar commented Jan 6, 2019

@konsultaner It's good to have feature. I reviewed your work and it looks good to me 👍
The only thing which I think should be changed is the name of the key. I couldn't get in the first round what does encryptionRealm mean.
Also, it would be great if you could update the README.md with the explanation. It would be very useful for the users to know and understand such thing is also provided by the lib.

Great work 👍

@konsultaner
Copy link
Contributor Author

@softvar What about encryptionNamespace?

@konsultaner
Copy link
Contributor Author

@softvar Is there still something you worry about? I'm done with this PR so far.

@konsultaner
Copy link
Contributor Author

konsultaner commented Jan 11, 2019

@softvar regarding #22. I could fix this issue with this PR if

do want me to do so?

@softvar
Copy link
Owner

softvar commented Jan 11, 2019

@konsultaner That's great. Thanks for doing this.

@softvar softvar merged commit 5bffc51 into softvar:master Jan 11, 2019
@softvar
Copy link
Owner

softvar commented Jan 11, 2019

Merged. Updated yarn.lock and map files due to the changes. Tagged.
v1.2.5 contains your changes 👍
Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants