Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a crate for handling starknet_artifacts.json file from scarb #2141

Closed
cptartur opened this issue Jun 27, 2023 · 2 comments
Closed

Create a crate for handling starknet_artifacts.json file from scarb #2141

cptartur opened this issue Jun 27, 2023 · 2 comments
Assignees
@cptartur

Comments

@cptartur
Copy link
Member

cptartur commented Jun 27, 2023 •
edited by Arcticae

We're handling starknet_artifacts.json file both in the rust runner and CLI. Code for deserializing and handling this file could be moved to a separate crate and used in both these projects.

Should include swapping code parts in CLI/rust runner which parse the artifacts
@piotmag769 piotmag769 mentioned this issue Jun 28, 2023
Merged
@Arcticae
Copy link
Member

For now, create a separate crate and we'll merge it into one workspace when we have a new repo

@piotmag769
Copy link
Contributor

#2138 (comment)
We should also implement better error messages for cases where a user changes the content of Scarb.toml (like removing [[target.starknet-contract]] or adding sierra=false to the starknet target

@cptartur cptartur self-assigned this Jun 30, 2023
@cptartur cptartur mentioned this issue Jul 6, 2023
Closed
@piotmag769 piotmag769 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arcticae @cptartur @piotmag769