Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cheatcodes panic in rust runner #2148

Closed
Radinyn opened this issue Jun 29, 2023 · 1 comment
Closed

Fix cheatcodes panic in rust runner #2148

Radinyn opened this issue Jun 29, 2023 · 1 comment
Assignees
@Radinyn
Milestone
Rust test runner

Comments

@Radinyn
Copy link
Contributor

Radinyn commented Jun 29, 2023 •
edited by cptartur

Cheatcodes should use HintError::CustomHint or another mechanism so they fail in the way that can be handled by rust vm. Currently if cheatcodes panic for whatever reason, they panic "in rust" and cause the whole runner to fail which cannot be nicely handled.
@Radinyn Radinyn self-assigned this Jun 29, 2023
@cptartur cptartur added this to the Rust test runner milestone Jun 29, 2023
@Radinyn Radinyn linked a pull request Jun 29, 2023 that will close this issue
Fix cheatcodes panic #2152
Closed
3 tasks
@MaksymilianDemitraszek
Copy link
Collaborator

@Radinyn @cptartur Can you provide some description?

@cptartur cptartur mentioned this issue Jul 6, 2023
Closed
@Radinyn Radinyn closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radinyn Radinyn

Labels
None yet
Projects
None yet
Milestone
Rust test runner
Development

Successfully merging a pull request may close this issue.

Fix cheatcodes panic software-mansion/protostar
3 participants
@MaksymilianDemitraszek @Radinyn @cptartur