-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing React-RCTImage dependency #2054
Comments
Yeah, this is rather unintended. Thanks for letting us know. Most likely we will bring back react-image to our dependency list, as we directly consume it. |
@stianjensen can you check if applying #2089 fixes the issue? |
Yes, looks like that solves it! For completeness, it only worked for me when I applied it on v3.27.0 – on the latest version v3.30.1 I then ran into another linker error, but that probably warrants its own issue (I haven't tested the versions between 3.27 and 3.30.1 yet).
|
@stianjensen That's great, thanks for confirming this resolves your issue! Also, if the error with undefined symbol still happens to you, could you create separate issue with it? 🙏 |
Try adding the following code to the RNScreens.podspec file in v3.27.0. if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
s.dependency "hermes-engine"
else
s.dependency "React-jsi"
end |
Description
When upgrading to react-native 0.73, I needed to upgrade react-native-screen to the latest version in order to make it build properly on Android.
Then I ran into an issue on iOS where
React-RCTImage
disappeared from the list of dependencies of RNScreens in Podfile.lock.It looks like it stems from this commit, which first shipped with v3.26.0:
c3d1ae8
React-RCTImage is only added to the list of dependencies if you're running in a react-native environment without
install_modules_dependencies
.The error I was getting was:
Patching the podspec locally to add back React-RCTImage (at least when running with
new_arch_enabled == false
, the only config I've tested so far), resolves the issue for me. Has it gotten lost in this case accidentally?I can see from the PRs to the example repo here as well that the dep got lost when updating the version of react-native-screens used in the example repositories:
#1979
For context, I am running with
use_frameworks!
in my Podfile, but have seen no issues with that and react-native-screens until now.Would it be possible to keep the dependency and thereby continue supporting this workflow?
Steps to reproduce
Install with use_frameworks! in your podfile, and then try to run on iOS.
Snack or a link to a repository
https://github.com/stianjensen/react-native-screens-test/tree/main
Screens version
3.29.0
React Native version
0.73.0
Platforms
iOS
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: