Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(iOS): transitionStart is not triggered for anything but default navigation #2178

Closed
hirbod opened this issue Jun 10, 2024 · 6 comments
Closed
Assignees
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@hirbod
Copy link
Contributor

hirbod commented Jun 10, 2024

Description

transitionStart is never reported for presentation modes other than the default. When switching to modal or transparentModal, it only reports transitionEnd. When closing the modal, it reports both transitionStart and transitionEnd.

If the target is pushed normally, it works correctly. This bug occurs only on iOS, not on Android. Open the snack with iOS and check the logs. I have added two buttons, both pushing to the same screen. Only the default one triggers both start and end, while the modal one only emits the end.

Steps to reproduce

Open my Snack and watch the console while testing both buttons.

transitionStart and transitionEnd should work for every presentation mode.
Here is a video showcasing everything:

repro.mp4

Snack or a link to a repository

https://snack.expo.dev/@hirbod/react-navigation-transition-event-bug?platform=ios

Screens version

3.21.0

React Native version

0.74.2

Platforms

iOS

JavaScript runtime

Hermes

Workflow

Expo bare workflow

Architecture

Paper (Old Architecture)

Build type

None

Device

Real device

Device model

All iOS devices

Acknowledgements

Yes

@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided labels Jun 10, 2024
@hirbod
Copy link
Contributor Author

hirbod commented Jun 10, 2024

Same issue applies to useTransitionProgress and useReanimatedTransitionProgress by the way.

@maksg
Copy link
Contributor

maksg commented Jul 3, 2024

Hey, @hirbod! Thanks for reporting the issue.
It should be fixed in react-navigation 6.10.0 by this PR react-navigation/react-navigation#11803.
If you're still having problems with this, please open a separate issue with reproduction steps.

@maksg maksg closed this as completed Jul 3, 2024
@hirbod
Copy link
Contributor Author

hirbod commented Jul 3, 2024

@maksg did you test my issue with the new update before blindly closing it? I have attached a Snack and all reproduction steps.

@maksg
Copy link
Contributor

maksg commented Jul 3, 2024

@hirbod Yes, we did test that with your example, it wasn't blindly closed. It was reproducible with the project you provided and the issue disappeared when we upgraded react-navigation to 6.10.0 in your sample.

@hirbod
Copy link
Contributor Author

hirbod commented Jul 3, 2024

Thank you very much. I think I misunderstood your reply, thanks a ton! ❤️

@hirbod
Copy link
Contributor Author

hirbod commented Jul 3, 2024

@maksg I've just confirmed that it's working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

2 participants