Support RPC 0.2.1 + drop deploy transaction #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 70.69% // Head: 70.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## milestone/0.4.0 #212 +/- ##
===================================================
- Coverage 70.69% 70.19% -0.51%
===================================================
Files 56 58 +2
Lines 1573 1778 +205
Branches 114 117 +3
===================================================
+ Hits 1112 1248 +136
- Misses 430 492 +62
- Partials 31 38 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Solpatium
requested review from
Solpatium and
cptartur
and removed request for
Solpatium
cptartur
reviewed
Dec 14, 2022
...in/com/swmansion/starknet/data/serializers/JsonRpcTransactionReceiptPolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/Contracts.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/Contracts.kt
Outdated
Show resolved
Hide resolved
THenry14
force-pushed
the
szymczyk/146-rpc21
branch
from
3321399
to
aad62f8
Compare
cptartur
reviewed
Dec 16, 2022
...in/com/swmansion/starknet/data/serializers/JsonRpcTransactionReceiptPolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/ContractClassGatewaySerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/TransactionReceipt.kt
Show resolved
Hide resolved
Solpatium
suggested changes
Dec 19, 2022
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/exceptions/RequestFailedException.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/rpc/JsonRpcProvider.kt
Outdated
Show resolved
Hide resolved
cptartur
reviewed
Dec 21, 2022
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/Responses.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/gateway/GatewayProvider.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/rpc/JsonRpcProvider.kt
Outdated
Show resolved
Hide resolved
THenry14
force-pushed
the
szymczyk/146-rpc21
branch
from
d4e4939
to
54b8c4d
Compare
…Index, pendingTransactions and addDeployAccountTransaction
THenry14
force-pushed
the
szymczyk/146-rpc21
branch
from
54b8c4d
to
2c8c200
Compare
cptartur
reviewed
Dec 22, 2022
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/HexToIntSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/exceptions/RequestFailedException.kt
Show resolved
Hide resolved
THenry14
force-pushed
the
szymczyk/146-rpc21
branch
from
2530658
to
4631f70
Compare
Solpatium
suggested changes
Jan 3, 2023
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/HexToIntSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/exceptions/RequestFailedException.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/gateway/GatewayProvider.kt
Outdated
Show resolved
Hide resolved
This was referenced Jan 11, 2023
Solpatium
suggested changes
Jan 12, 2023
lib/src/main/kotlin/com/swmansion/starknet/data/serializers/TransactionPolymorphicSerializer.kt
Outdated
Show resolved
Hide resolved
Solpatium
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces support for RPC 0.2.1 spec and drops support for deploy transaction (gateway + rpc).
Linked issues
Closes #146
Closes #148
Closes #190
Closes #184
Closes #202
Breaking changes
This issue contains breaking changes
RPC 0.1.0 support is dropped
provider.deployContract is dropped