Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't redirect using POST on login #34

Closed
bartekczyz opened this issue Nov 3, 2020 · 2 comments · Fixed by #35
Closed

Don't redirect using POST on login #34

bartekczyz opened this issue Nov 3, 2020 · 2 comments · Fixed by #35
Labels
released on @alpha released

Comments

@bartekczyz
Copy link
Contributor

bartekczyz commented Nov 3, 2020 •
edited
Loading

PR: #35

Problem

Currently after POST on loginPath you're being redirected to either rootPath or redirectTo from session. The problem is, it uses 307 redirect which keeps the request method and form data.

In some circumstances (eg. using with nestjs) you might end up with redirecting to the rootPath AS a POST request, so you'll see the message that route POST ${rootPath} does not exist.

Solution

Redirect from POST loginPath using 302 status
@bartekczyz bartekczyz mentioned this issue Nov 3, 2020
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(login): explicitly use 302 status while redirecting POST request bartekczyz/admin-bro-expressjs
1 participant
@bartekczyz