Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .scss instead of .sass #7

Closed
wojtek-krysiak opened this issue Mar 20, 2019 · 1 comment
Closed

Use .scss instead of .sass #7

wojtek-krysiak opened this issue Mar 20, 2019 · 1 comment

Comments

@wojtek-krysiak
Copy link
Contributor

Use .scss instead of .sass

  • It's still SASS, just a modern, more familiar version of SASS which makes contributing easier. Also, CSS is valid SCSS.
  • Using @extend to create base styles from which other styles can extend. This results in a performant stylesheet that renders all shared styles in single declaration blocks, and aberrant styles, i.e., one-off margin adjustments, etc. to their respective component blocks.
  • Adding typography.scss
    • All font-related styles integrated into a single place
  • removing third-party (vendor) CSS and use npm to ease the upgrade process for those vendor styles, e.g., prettify styles.
@wojtek-krysiak wojtek-krysiak created this issue from a note in Better-docs 2.0.0 (To do) Mar 20, 2019
@JustinBeaudry
Copy link

I've got this one done as well. Just need to make a PR. Can you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants