Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swagger 5.0 #2958

Closed
adamw opened this issue Jun 12, 2023 · 3 comments
Closed

Support Swagger 5.0 #2958

adamw opened this issue Jun 12, 2023 · 3 comments

Comments

@adamw
Copy link
Member

adamw commented Jun 12, 2023

See: https://github.com/swagger-api/swagger-ui/releases/tag/v5.0.0

To consider: do we want to update the swagger modules, or create mirror ones, for swagger 5?

When generating the openapi spec for the new swagger, we should enable openapi 3.1

@gaeljw
Copy link
Contributor

gaeljw commented Jun 12, 2023

It's not clear to me if there's any real breaking changes from Swagger UI 4.x to 5.x. I only see new features. Is the UI even different at all? (Real question, I haven't had time to check yet).

I'd say that most people that need a specific version of SwaggerUI with customisations already do not use Tapir's integrated Swagger UI bundle but their own. Thus a slight preference to not creating an additional module.

On the other hand, as Tapir aims to be compatible with multiple other libs/frameworks. It would make sense to support both 4.x and 5.x at least for some time.

Not a really helpful answer 😅

@kciesielski
Copy link
Member

There are no breaking changes, it's fully backward compatible, I'd just update the current swagger module.

@adamw
Copy link
Member Author

adamw commented Jul 7, 2023

Done in #2979

@adamw adamw closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants