Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not double slash when context path is root #47

Merged
merged 1 commit into from
Aug 24, 2015
Merged

Conversation

jcgay
Copy link
Contributor

@jcgay jcgay commented Aug 21, 2015

At least with Tomcat (not reproduced with Jetty), ServletContext#getContextPath
returns '/'. When Jersey servlet is mapped on '/something', we ends by creating links
starting with '//something' which is wrong...

At least with Tomcat (not reproduced with Jetty), ServletContext#getContextPath
returns '/'. When Jersey servlet is mapped on '/something', we ends by creating links
starting with '//something' which is wrong...
@nicokosi
Copy link

Cool. 😎

I have a build issue which is not related to this change (I cannot build branch master either):

[INFO] Reactor Summary:
[INFO]
[INFO] JAX-RS Linker: parent POM .......................... SUCCESS [ 1.209 s]
[INFO] JAX RS Linker ...................................... SUCCESS [ 11.511 s]
[INFO] JAX RS Linker: integration test suite .............. SUCCESS [ 0.007 s]
[INFO] JAX RS Linker: webapp without any XML configuration FAILURE [ 2.305 s]
[INFO] JAX RS Linker: webapp with web.xml ................. SKIPPED
[INFO] JAX-RS Linker: webapp without JAX-RS Configuration . SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.293 s
[INFO] Finished at: 2015-08-24T08:55:26+02:00
[INFO] Final Memory: 34M/818M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.jetty:jetty-maven-plugin:9.3.0.M1:run-forked (start-server) on project no-xml-webapp: Unable to parse configuration of mojo org.eclipse.jetty:jetty-maven-plugin:9.3.0.M1:run-forked for parameter webApp: Cannot create instance of class org.eclipse.jetty.maven.plugin.JettyWebAppContext: org/slf4j/helpers/MessageFormatter: org.slf4j.helpers.MessageFormatter -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginConfigurationException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :no-xml-webapp

Is this a configuration issue on my machine? 🎱

@nicokosi
Copy link

I merge (Travis build is OK):
https://travis-ci.org/softwarevidal/jax-rs-linker/jobs/76660101

@nicokosi nicokosi merged commit 84011b8 into master Aug 24, 2015
@nicokosi nicokosi deleted the root-context-path branch August 24, 2015 07:15
@nicokosi
Copy link

For information, I had a local build issue related to a Maven extension, maven-color (https://github.com/jcgay/maven-color). I applied a patch (http://jeanchristophegay.com/binaries/maven-core-3.3.3.jar, thanks @jcgay) that fixed it. 🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants