Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.0.13 is mostly ready but is not released #57

Closed
sogaiu opened this issue Jan 26, 2024 · 13 comments
Closed

Version 0.0.13 is mostly ready but is not released #57

sogaiu opened this issue Jan 26, 2024 · 13 comments

Comments

@sogaiu
Copy link
Owner

sogaiu commented Jan 26, 2024

Now that tree-sitter 0.20.9 has been released perhaps it's good to move toward releasing 0.0.13 (see this link for a reminder of what we had planned on before).

I have run various tests (against the corpus and our large collection of samples) using tree-sitter 0.20.9 on the post-0.0.12 branch and found no unexpected issues.

Since it has been a while since the last tree-sitter release, I suppose it might not be surprising if issues with it surface.

I was going to suggest waiting a bit before releasing 0.0.13, but may be moving forward with making an announcement at #33 is fine as we've typically waited about 2 weeks after announcing to actually release.

If some issue turns up during those 2 weeks we can revisit our plans.

@dannyfreeman Any thoughts?

Update: there is now a pre-0.0.13 branch.

@NoahTheDuke
Copy link

I don't think anyone will be annoyed by you waiting a bit to see how the dust settles.

@dannyfreeman
Copy link
Collaborator

There is nothing from me. Not very active on github atm, but I will test out and make sure nothing is broken sometime this next week and report back. Thank you.

@sogaiu
Copy link
Owner Author

sogaiu commented Jan 30, 2024

Thanks a lot for the offer, highly appreciated!

I don't think we're in a hurry to release soon -- the stated date in the announcement is only an initial target. If it happens we are ready then, we'll go ahead, otherwise we can postpone.

@sogaiu
Copy link
Owner Author

sogaiu commented Feb 2, 2024

On a side note, a new issue titled "Tree-Sitter Roadmap" showed up at the tree-sitter repository.

Might be worth scanning to see what's on the minds of the maintainers...

Of note is one of dannyfreeman's issues titled "Grammar versions and dealing with breaking changes". This is listed under the "Issues to tackle" section of the planned release of 0.20.10 in April of this year.

The following text was also present:

For those reading this that wish to help out or move any issue they'd like fixed or feature they'd like implemented, don't hesitate! Draft a PR, ask questions, or reach out in the discord to chat more! Any help is appreciated as long as it's high quality and well-thought-out.

Perhaps it includes pointing out issues that aren't listed on that page? This issue doesn't appear to be listed and it came up for us here.

@sogaiu
Copy link
Owner Author

sogaiu commented Feb 12, 2024

@dannyfreeman Sorry to bug you. Did you happen to have time to take a look?

@sogaiu
Copy link
Owner Author

sogaiu commented Feb 22, 2024

For reference, tree-sitter 0.21.0 was released.

It looks like the default API level is still 14.

There's a changelog here.


I am still inclined to release v0.0.13 based on tree-sitter 0.20.9 though.

@sogaiu
Copy link
Owner Author

sogaiu commented Feb 22, 2024

Regarding:

tree-sitter/tree-sitter#2012 doesn't appear to be listed and it came up for us #32.

I asked one of the maintainers and he said something to the effect that the desire to fix exists, but exactly what to do was not clear.

@sogaiu
Copy link
Owner Author

sogaiu commented Mar 15, 2024

It looks like multiple releases have occurred since this issue was created (^^;

We're now up to 0.22.1. The changelog is tiny for that, so might be better to look at 0.22.0 if interested in seeing what has changed.


Haven't digested the content in full, but one minor thing I noticed is:

Remove top-level corpus dir for tests
The cli will now only look in test/corpus for tests

Good thing we changed that in this commit.

@sogaiu
Copy link
Owner Author

sogaiu commented May 15, 2024

I've finally tagged a release as v0.0.13.

Thanks for your patience :)

Hope things are going well for everyone.

@sogaiu sogaiu closed this as completed May 15, 2024
@NoahTheDuke
Copy link

looks like you didn't regenerate with latest version of tree-sitter. did you want to do that?

@sogaiu
Copy link
Owner Author

sogaiu commented May 15, 2024

Thanks for stopping by :)

looks like you didn't regenerate with latest version of tree-sitter. did you want to do that?

No, not at this time.

I've been watching recent developments of tree-sitter and I don't feel it has reached what seems like a stable-ish version. Multiple releases have been made in a fairly short period and they all still generate a src/parser.c file with a API number of 14 by default (like 0.20.9 does).

Did the latest version seem somehow better than what I used? My impression is that there isn't anything significant to be gained by generating with a more recent version of the tree-sitter cli, but may be I missed something (^^;

@NoahTheDuke
Copy link

I don't think you missed anything, I just have a vague memory of that being a point of discussion a few months ago when you first started preparing for this release. Thought it better to double check. Thanks for the release!

@sogaiu
Copy link
Owner Author

sogaiu commented May 15, 2024

Yeah, I agree it's good to confirm.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants