Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customvariable): log warning on unprivileged variable change #4534

Merged
merged 3 commits into from Jan 11, 2021
Merged

Conversation

sogehige
Copy link
Collaborator

Fixes #4528

CHECKLIST

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #4534 (6559909) into master (8f5ed8a) will increase coverage by 0.01%.
The diff coverage is 82.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4534      +/-   ##
==========================================
+ Coverage   57.18%   57.20%   +0.01%     
==========================================
  Files         250      256       +6     
  Lines       15237    15285      +48     
  Branches     2939     2946       +7     
==========================================
+ Hits         8714     8744      +30     
- Misses       6523     6541      +18     
Flag Coverage Δ
mysql 57.05% <82.00%> (-0.07%) ⬇️
postgres 57.08% <82.00%> (+0.15%) ⬆️
sqlite 57.02% <82.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bot/helpers/points/getPointsName.ts 46.66% <46.66%> (ø)
src/bot/filters/price.ts 62.50% <50.00%> (ø)
src/bot/integrations/discord.ts 19.53% <50.00%> (ø)
src/bot/permissions.ts 46.61% <50.00%> (-4.93%) ⬇️
src/bot/systems/bets.ts 67.93% <50.00%> (+1.26%) ⬆️
src/bot/systems/price.ts 54.95% <66.66%> (+4.04%) ⬆️
src/bot/systems/userinfo.ts 49.44% <75.00%> (ø)
src/bot/filters/list.ts 71.31% <85.00%> (ø)
src/bot/_interface.ts 55.97% <88.88%> (+0.41%) ⬆️
src/bot/games/duel.ts 98.27% <100.00%> (+0.01%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778dfa6...6559909. Read the comment docs.

@sogehige sogehige merged commit 601a010 into master Jan 11, 2021
@sogehige sogehige deleted the 4528 branch January 11, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log warning if user don't have permission to change variable
1 participant